Conversation
Member
Author
|
Also, in future pps will live in other repository in jjs-dev org. |
MikailBag
force-pushed
the
pps
branch
3 times, most recently
from
063edbd to
9dcf426
Compare
MikailBag
commented
Aug 24, 2020
| @@ -1,4 +1,4 @@ | |||
| #![feature(proc_macro_hygiene, type_alias_impl_trait)] | |||
| #![type_length_limit = "4323264"] | |||
Member
Author
There was a problem hiding this comment.
This is issue in either rust or tracing.
old name: problem package compiling (not cool) new name: problem preparation system (or services, as you wish) (cooler) new architecture: CLI and server CLI starts server in background and sends RPC requests to the server. Server actually does stuff. In future it will be possible to start one server which will process requests from many clients. RPC protocol is based on HTTP POST requests and defined via Rust structs. In future, we should make consuming PPS api from other languages easier (e.g. provide JSON schema for types). Also, it's worth extracting RPC implementation into jjs-commons.
Member
Author
|
bors r+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
old name: problem package compiling (not cool)
new name: problem preparation system (or services, as you wish) (cooler)
new architecture: CLI and server
CLI starts server in background and sends RPC requests to the server.
Server actually does stuff.
In future it will be possible to start one server which will process
requests from many clients.
RPC protocol is based on HTTP POST requests and defined via Rust
structs. In future, we should make consuming PPS api from other
languages easier (e.g. provide JSON schema for types).
Also, it's worth extracting RPC implementation into jjs-commons. (UPD: done)