use stable sort to support ruby >= 2.5#39
Closed
jmartin-tech wants to merge 4 commits intojjyg:masterfrom
Closed
Conversation
Due to changes in quicksort implementaions available in the revised compiler for used for windows on ruby >= 2.5 we need to ensure the sort it stable for intructions when selecting during encode.
busterb
added a commit
to rapid7/metasploit-framework
that referenced
this pull request
Apr 8, 2019
msjenkins-r7
pushed a commit
to rapid7/metasploit-framework
that referenced
this pull request
Apr 8, 2019
jmartin-tech
force-pushed
the
ruby_2_5_compat
branch
from
d253ad2 to
20a0750
Compare
Author
Contributor
|
Howdy, anything we can do to help move this into the upstream sources? |
Contributor
|
Note that because the sort routine changed, metasm selected a different encoding by default. This seemed to break some shellcode generated inside of Metasploit, but also possibly pointed to some bad alternate encodings in metasm as well. We may be able to resurrect the affected code and track that down as well. |
Author
|
Can this get merged? |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes in quicksort implementaions available in the
revised compiler for used for windows on ruby >= 2.5 we need
to ensure the sort it stable for intructions when selecting during
encode.