impl Drop for FileDescriptor/OwnedFileDescriptor

[abdullah-albanna]

No description provided.

[jkcoxson]

I've just created a test harness, do you mind running the tests to make sure everything still works? This code adds unsafe, so I want the afc test suite to be run beforehand.

[abdullah-albanna]

yeah it works just fine

you wouldn't notice anything even if it's broken, because drop doesn't panic in here

you should test the dropping, like get the fd out, and drop it and try to open it again, if it panics then it's good

[abdullah-albanna]

I'm not sure about the tokio::task::block_in_place and if it's appropriate for Drop

you can keep this pr open until you feel comfortable, or someone else confirms it's okay

[jkcoxson]

Do you mind upstreaming your changes so I can test it with the new harness? I can't do it myself since your branch is also master.

[jkcoxson]

I added a drop so we don't mutably borrow twice and tested it on the vphone test harness. If you agree with my change, we can merge this.

[abdullah-albanna]

ok