Fix rename not accounted in the hash computation #63
Merged
jkent merged 1 commit intojkent:mainfrom Aug 25, 2024
Merged
Conversation
…o find files in subfolders
jkent
reviewed
Aug 25, 2024
| if 'meta' in transform: | ||
| dest = pipe_script(transform['path'], args, str.encode(ent['dest'])).decode() | ||
| ent['dest'] = dest | ||
| ent['name'] = dest.split('/')[-1] |
Owner
There was a problem hiding this comment.
This threw me off, but I see you're doing it for completeness. Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current code, if a rename transform is set up, the renamed file isn't findable directly via frogfs_get_entry (it's accessible via opendir/readdir).
This is because the hash was computed on the previous name (without renaming).
This patch solves the issue by using the destination name. So now, it's possible to get an entry directly and via opendir/readdir too.