Add frogs vfs deregister#67
Merged
jkent merged 2 commits intojkent:mainfrom Jun 30, 2025
Merged
Conversation
Contributor
Author
|
@jkent A minor addition, let me know if any comment. Cheers. |
jkent
requested changes
Jun 27, 2025
Owner
jkent
left a comment
jkent
left a comment
There was a problem hiding this comment.
Thank you for your contribution! There are a few things I'd like to see done before I merge this pull request.
g-provost
force-pushed
the
feat/vfs-deregister
branch
from
f541d20 to
c4096b4
Compare
Owner
|
Looks good! Thank you again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A VFS deregister function was missing if for example we want to properly unmount/mount a frogfs file after an update.