Skip to content

Conversation

@eahoegner
Copy link
Collaborator

adjusted to match new file names and folder structure for updated regionmappings

Copy link
Owner

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, two small changes then we can merge.

Comment on lines +11 to +12
data_path: "/home/hoegner/Projects/CMIP7/" # Annika
# data_path: "C:/Users/kikstra/IIASA/ECE.prog - Documents/Projects/CMIP7/IAM Data Processing/concordia_cmip7_v0_testing" # Jarmo
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it unchanged for now?

Comment on lines 48 to 62
# GCAM 7.1 scenarioMIP:
# path: "$regionmappings_path/tbd.csv"
# path: "$regionmappings_path/region_definitions_GCAM 7.1.csv"
# country_column: "iso"
# region_column: "tbd"
# sep: ","
# IMAGE 3.4:
# path: "$regionmappings_path/tbd.csv"
# path: "$regionmappings_path/region_definitions_IMAGE 3.4.csv"
# country_column: "iso"
# region_column: "tbd"
# sep: ","
# WITCH 6.0:
# path: "$regionmappings_path/tbd.csv"
# path: "$regionmappings_path/region_definitions_WITCH 6.0.csv"
# country_column: "iso"
# region_column: "tbd"
# sep: ","
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can all be uncommented now

Copy link
Owner

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eahoegner can you please revert the data/compare_wfd_inputs commit?

@eahoegner eahoegner requested a review from jkikstra June 25, 2025 12:56
@eahoegner
Copy link
Collaborator Author

one question @jkikstra. we are here using three country combinations:

  sdn_ssd: ["ssd", "sdn"]
  isr_pse: ["isr", "pse"]
  srb_ksv: ["srb", "srb (kosovo)"]

however, in the historical data from CEDS and BB4CMIP7 we only aggregate srb_ksv. CEDS does report ssd and sdn, but no pse. BB4CMIP7 i can't check right now, need to re-download first when back in better wifi. but it would make sense to resemble historical here, wouldn't it?

@eahoegner
Copy link
Collaborator Author

actually, our aggregated historical dataset does have pse, although only for 40 species/sector combinations rather than 120 and with NaNs for earlier years. so I guess we can do the country combinations, but have to also do them for hist as well

@jkikstra
Copy link
Owner

actually, our aggregated historical dataset does have pse, although only for 40 species/sector combinations rather than 120 and with NaNs for earlier years. so I guess we can do the country combinations, but have to also do them for hist as well

40, not 120 - does that mean only fires has PSE?

@eahoegner
Copy link
Collaborator Author

seems like it, yes. i assume then that means we should aggregate this, otherwise parts of the emissions are counted under isr and parts under pse

@eahoegner
Copy link
Collaborator Author

downscaling spans 194 countries now

@jkikstra
Copy link
Owner

seems like it, yes. i assume then that means we should aggregate this, otherwise parts of the emissions are counted under isr and parts under pse

agreed

@jkikstra
Copy link
Owner

Would be good to create an overview of how to aggregate all data from GFED and CEDS, into the highest number of countries that can be uniquely matched to the GDP data.
Not sure if GDP data would also need to be aggregated.
For instance, pse and isrl.

kosovo should now be in the new GDP data though - probably as XKX (link)

@jkikstra
Copy link
Owner

jkikstra commented Jul 4, 2025

Thanks a lot for this.

I think we need a strategy of how to deal with small territories/missing countries.

data:

For this, we want to understand

  • how the current workflow deals with emissions for 'missing' regions
  • how we make sure we're not 'losing' any emissions
  • how we make sure that the downsclaing of combined regions makes sense
  • how we make sure that the gridding of combined regions makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants