-
Notifications
You must be signed in to change notification settings - Fork 1
updated yaml for regionmapping files #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jkikstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, two small changes then we can merge.
| data_path: "/home/hoegner/Projects/CMIP7/" # Annika | ||
| # data_path: "C:/Users/kikstra/IIASA/ECE.prog - Documents/Projects/CMIP7/IAM Data Processing/concordia_cmip7_v0_testing" # Jarmo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it unchanged for now?
| # GCAM 7.1 scenarioMIP: | ||
| # path: "$regionmappings_path/tbd.csv" | ||
| # path: "$regionmappings_path/region_definitions_GCAM 7.1.csv" | ||
| # country_column: "iso" | ||
| # region_column: "tbd" | ||
| # sep: "," | ||
| # IMAGE 3.4: | ||
| # path: "$regionmappings_path/tbd.csv" | ||
| # path: "$regionmappings_path/region_definitions_IMAGE 3.4.csv" | ||
| # country_column: "iso" | ||
| # region_column: "tbd" | ||
| # sep: "," | ||
| # WITCH 6.0: | ||
| # path: "$regionmappings_path/tbd.csv" | ||
| # path: "$regionmappings_path/region_definitions_WITCH 6.0.csv" | ||
| # country_column: "iso" | ||
| # region_column: "tbd" | ||
| # sep: "," |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can all be uncommented now
jkikstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eahoegner can you please revert the data/compare_wfd_inputs commit?
|
one question @jkikstra. we are here using three country combinations: however, in the historical data from CEDS and BB4CMIP7 we only aggregate |
|
actually, our aggregated historical dataset does have pse, although only for 40 species/sector combinations rather than 120 and with NaNs for earlier years. so I guess we can do the country combinations, but have to also do them for hist as well |
40, not 120 - does that mean only fires has PSE? |
|
seems like it, yes. i assume then that means we should aggregate this, otherwise parts of the emissions are counted under isr and parts under pse |
|
downscaling spans 194 countries now |
agreed |
|
Would be good to create an overview of how to aggregate all data from GFED and CEDS, into the highest number of countries that can be uniquely matched to the GDP data. kosovo should now be in the new GDP data though - probably as XKX (link) |
|
Thanks a lot for this. I think we need a strategy of how to deal with small territories/missing countries. data:
For this, we want to understand
|
adjusted to match new file names and folder structure for updated regionmappings