Dynamic Partial (lookup) with a "default" parameter doesn't work

[gatim]

Hi,

The last version of this project (4.0.5) with a JDK 1.7 works pretty well but I think that I have found a problem.

The following code throws an exception:
{{> (lookup myObject 'aVariable') myObject.otherObject}}

com.github.jknack.handlebars.HandlebarsException: /template/common/aTemplate.hbs:4:78: found: '}}', expected: '='
      {{> (lookup myObject 'aVariable') myObject.otherObject}}
                                      ^
    at com.github.jknack.handlebars.internal.HbsErrorReporter.syntaxError(HbsErrorReporter.java:93)
    at org.antlr.v4.runtime.ProxyErrorListener.syntaxError(ProxyErrorListener.java:65)
    at org.antlr.v4.runtime.Parser.notifyErrorListeners(Parser.java:566)
    at com.github.jknack.handlebars.internal.HbsErrorStrategy.reportInputMismatch(HbsErrorStrategy.java:186)
    at org.antlr.v4.runtime.DefaultErrorStrategy.reportError(DefaultErrorStrategy.java:148)
    at com.github.jknack.handlebars.internal.HbsParser.hash(HbsParser.java:2096)
    at com.github.jknack.handlebars.internal.HbsParser.pexpr(HbsParser.java:1764)
    at com.github.jknack.handlebars.internal.HbsParser.partial(HbsParser.java:1563)
    at com.github.jknack.handlebars.internal.HbsParser.statement(HbsParser.java:373)
    at com.github.jknack.handlebars.internal.HbsParser.body(HbsParser.java:222)
    at com.github.jknack.handlebars.internal.HbsParser.template(HbsParser.java:165)
    at com.github.jknack.handlebars.internal.HbsParserFactory$1.parse(HbsParserFactory.java:84)
    at com.github.jknack.handlebars.cache.NullTemplateCache.get(NullTemplateCache.java:54)
    at com.github.jknack.handlebars.Handlebars.compile(Handlebars.java:414)
    at com.github.jknack.handlebars.Handlebars.compile(Handlebars.java:357)
    at com.github.jknack.handlebars.Handlebars.compile(Handlebars.java:343)
    at be.smals.hfcse.emsr.kmehrvalidation.core.TemplateTest.testT(TemplateTest.java:76)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.lang.reflect.Method.invoke(Unknown Source)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
    at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:86)
    at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:459)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:678)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:382)
    at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:192)

I have tried this code in javascript and it works.

NOTE: There is a work around for this problem but the context of the called template is not changed.

You have to define a parameter explicitly:
{{> (lookup myObject 'aVariable') myParam=myObject.otherObject}}

And use it in the other template like that:
{{myParam.otherObject.otherVariable}}

[jknack]

Hi,

We have a parser issue here which I'm going to fix, but... can you provide some data and expected output?

Thanks

[gatim]

Ok, here is my example:
dynamic_partial_template.zip

This code allow to load a partial template dynamically for each employees thanks to their profession.

[jknack]

Very nice example. I will fix this late today and make a new release 4.0.6

Also, I invite you to try: http://jooby.org

[gatim]

Thanks you for your work. Personally, we are not in a hurry for the release so if you want do something else for this release you can.

I will take a look to jooby ;)

Note: Damn I have do a mistake with the close button -_-

[jancona]

This fix appears to have broken one of my templates because it expects a failed lookup to return a null. Could you explain why a failed lookup should return the context object?

[gatim]

If I understand well you do something like:
{{> (lookup context 'template') context.valueThatDoesntExist }}

I think you have right. The called template should have a context equals to null (js exemple).