Skip to content

Allow carriage return and tabs.#699

Closed
mathijs81 wants to merge 1 commit intojknack:masterfrom
mathijs81:master
Closed

Allow carriage return and tabs.#699
mathijs81 wants to merge 1 commit intojknack:masterfrom
mathijs81:master

Conversation

@mathijs81
Copy link
Copy Markdown
Contributor

After upgrading handlebars, some of our templates stopped working.
We tracked it down to carriage returns and tabs being part of identifiers now.

This led to some helpers not working anymore, for instance:

{{helper param1="something"
<tab><tab>param2="something else"}}

This change fixes that (and adds a test to check that the parse tree of various ways to format this are the same).

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #699 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #699   +/-   ##
=========================================
  Coverage     87.33%   87.33%           
  Complexity      841      841           
=========================================
  Files            78       78           
  Lines          3023     3023           
  Branches        411      411           
=========================================
  Hits           2640     2640           
  Misses          261      261           
  Partials        122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d8df2...1eaa930. Read the comment docs.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 91.366% when pulling 1eaa930 on mathijs81:master into 91d8df2 on jknack:master.

@mathijs81
Copy link
Copy Markdown
Contributor Author

Is anybody looking at this?

@jknack jknack added this to the 4.1.3 milestone Apr 25, 2020
@jknack
Copy link
Copy Markdown
Owner

jknack commented Apr 25, 2020

hey, sorry for late response. I copy your work and added it manually.

Thanks

@jknack jknack closed this Apr 25, 2020
jknack added a commit that referenced this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants