fix no func mode (-N)

[jkool702]

Summary by Sourcery

Fix and improve handling of no-function mode (-N) in forkrun bash script

Bug Fixes:

• Corrected delimiter removal string for no-function mode
• Fixed position reading from /proc/self/fdinfo to handle file offsets correctly

Enhancements:

• Improved parsing of file descriptor positions
• Added support for different file offset reading methods

[sourcery-ai]

Reviewer's Guide

This pull request refactors how file descriptor positions are read and compared within the script, primarily by explicitly setting IFS when parsing /proc/self/fdinfo and introducing lseek as an alternative method. It also adjusts a sed command and removes global IFS modifications related to the no-function mode (-N).

File-Level Changes

Change	Details	Files
Refactored file descriptor position reading from /proc.	Explicitly set IFS=$'\t' before reading /proc/self/fdinfo/* to reliably parse the position. Updated variable assignments to directly use the parsed position value instead of pattern matching (##*). Adjusted byte calculation (nBytes) based on the new position reading method.	forkrun.bash
Introduced conditional use of lseek for position checking.	Added logic to use lseek to get current read/write file descriptor positions if lseekFlag is true. Used the /proc/self/fdinfo/* reading method (with explicit IFS) as a fallback if lseekFlag is false. Standardized the comparison of read and write positions.	forkrun.bash
Adjusted logic related to the no-function mode (-N).	Corrected a sed command string used for delimiter removal. Removed lines that globally modified IFS within the generated command string.	forkrun.bash

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @jkool702 - I've reviewed your changes - here's some feedback:

• Consider if removing the explicit IFS settings within the noFuncFlag block could affect executed commands sensitive to IFS.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}