Skip to content

Share mapped memory to the host when guest is in init phase#51

Open
joukkone wants to merge 1 commit intomasterfrom
pr_sharemem
Open

Share mapped memory to the host when guest is in init phase#51
joukkone wants to merge 1 commit intomasterfrom
pr_sharemem

Conversation

@joukkone
Copy link
Collaborator

Signed-off-by: Jouni Ukkonen jouni.ukkonen@unikie.com

Signed-off-by: Jouni Ukkonen <jouni.ukkonen@unikie.com>
@joukkone joukkone requested review from janik-h and jkrh January 25, 2023 07:14
Copy link
Collaborator

@janik-h janik-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the area is not added to shared page bookkeeping (check set_share). Due to this any logic that depends on the is_share do not work for those pages which are left shared during init phase.

@jkrh
Copy link
Owner

jkrh commented Jan 25, 2023

Wait why would you want to do this? Which pages are you trying to leave as shared?

@jkrh
Copy link
Owner

jkrh commented Jan 25, 2023

Besides, I think we go to RUNNING state already when the initial cpu issues PSCI_VERSION, so there shouldn't be any pages this actually leaves open.

@joukkone
Copy link
Collaborator Author

Wait why would you want to do this? Which pages are you trying to leave as shared?

If host blinding is enabled, crosvm/cuttlefish cause crash during init phase.

@jkrh
Copy link
Owner

jkrh commented Jan 25, 2023

That said, I don't think this is the right approach. You would need to check what the guest kernel attempts to share exactly and add a patch to the guest kernel to open it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments