Skip to content

Fix vector sparse#247

Merged
sjanssen2 merged 22 commits into
masterfrom
fix_vector_sparse
May 7, 2026
Merged

Fix vector sparse#247
sjanssen2 merged 22 commits into
masterfrom
fix_vector_sparse

Conversation

@sjanssen2
Copy link
Copy Markdown
Member

@sjanssen2 sjanssen2 commented May 7, 2026

This PR is for maintenance. Triggered by the migration to "Debian GNU/Linux 13 (trixie)", Elena found that boost/cstdint.hpp is no longer available. This is due to the fact that functionality was meanwhile integrated into C libs; thus we now can #include <cstdint> instead of #include "boost/cstdint.hpp".

I furthermore found that ubuntu 20.04 and osx13 are no longer available for github actions and thus dropped 20.04 and switched from osx13 to osx14. This in turn revealed some issues with include/lib paths for the osx runner AND a bug in the sparse_vector implementation. I used claude to find a workaround but don't fully understand if this really fixed the bug - at least it does not lead to failures in our tests AND passed compilation in osx14 :-)

Note that the usual mod-tests failed, when compared to truth - as they often do when things changes due to heuristic aspects in the tabulation algorithm. There are still some osx14 tests failing with regards to checkpointing - an issue that I never fully resolved :-/ Please ignore for now.

@sjanssen2 sjanssen2 merged commit 3014f2b into master May 7, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants