Conversation
| @@ -1,5 +1,5 @@ | |||
| #ifndef HASH_STATS | |||
| #define HASH_STATS | |||
| #ifndef RTLIB_HASH_STATS_HH_ | |||
There was a problem hiding this comment.
Why is it considered a better style to add underscores at the end?
There was a problem hiding this comment.
honestly: I don't know and I cannot find anything about it in Google's styleguide: https://google.github.io/styleguide/cppguide.html#Header_Files
But hey, as long as it doesn't break anything we can comply to this rule
rtlib/table.hh
Outdated
| // std::cerr << "i " << i << " j " << j << " a " << | ||
| // a << " b " << b << std::endl; |
There was a problem hiding this comment.
I'm not sure if I like this style, personally. To split a single-line comment into two lines because - I assume - the comment is considered too long? But that's just personal preference.
There was a problem hiding this comment.
I personally agree, but for (historic) reasons, source code lines should never exceed 80 characters. I guess this is due to the fact that early day's terminals were exactly 80 characters wide and if you think of tools like diff it makes sense to have finite numbers of chars in a line. I would prefer a larger cut-off, but if the world picks 80 than let's go with it.
| #ifndef BIGINT_HH | ||
| #define BIGINT_HH | ||
| #ifndef RTLIB_BIGINT_HH_ | ||
| #define RTLIB_BIGINT_HH_ |
There was a problem hiding this comment.
Is this a cpplint thing or our own new standard of naming constants?
There was a problem hiding this comment.
I wouldn't have touched it if not cpplint is forcing me to do. It is their style.
3 participants
Similar to #31 for the sub-directory
rtlib/Bringing the number of warnings down from 4805 to "only" 606.
Let us merge #31 first!