Fix major performance regression and add benchmarking tools #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance fixes: - Cache word splitter instances using @cache decorator instead of creating new instances (with 891 pattern groups) for every paragraph - Add quick-reject optimization to skip pattern matching for words that cannot possibly match any pattern Result: 54x faster (6,300ms to 117ms), now 45% faster than v0.6.0 Also: - Add devtools/benchmark.py for comparing performance against releases - Add make benchmark and make profile targets - Rename html_md_word_splitter to get_html_md_word_splitter() with explicit atomic_tags parameter (no default to avoid bugs) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Performance fixes:
@cachedecorator instead of creating new instances (with 891 pattern groups) for every paragraphNew tooling:
devtools/benchmark.pyfor comparing performance against releasesmake benchmarkandmake profileMakefile targetsAPI cleanup:
html_md_word_splittertoget_html_md_word_splitter(atomic_tags: bool)with required explicit parameter to avoid bugsTest plan
Benchmark results
🤖 Generated with Claude Code