fix: Windows build compatibility - rename colon files to hyphens#3
Merged
Conversation
Windows does not allow colons in filenames, which was causing the CI build to fail. The speculate-cli update renamed all shortcut files from `shortcut:name.md` to `shortcut-name.md` format.
Now that shortcut files have been renamed from `shortcut:*.md` to `shortcut-*.md`, Windows builds should work correctly.
Coverage Report for packages/tbd-cli
File CoverageNo changed files found. |
- Added *.md to .prettierignore - Reformatted all markdown files with flowmark --auto - Flowmark provides semantic line breaks for better diffs
The CI coverage report was showing only vitest unit test coverage (9%) instead of the combined coverage. This happened because: - vitest wrote to coverage/ - tryscript wrote to coverage-tryscript/ - CI action read from coverage/ Fixed by: - Using --coverage-dir coverage to write merged report to same location - Using --coverage-monocart for accurate line counts aligned with vitest - Adding monocart-coverage-reports dependency - Including all required reporters (json, json-summary, lcov, html) This ensures CI now reports the full combined coverage from both unit tests and CLI golden tests.
New test files: - merge.test.ts: Comprehensive tests for three-way merge algorithm - LWW (last-write-wins) strategy for scalar fields - Union strategy for labels and dependencies - Max strategy for version numbers - Immutable strategy for IDs and timestamps - Conflict entry generation - errors.test.ts: Tests for CLI error classes - CLIError, ValidationError, NotInitializedError - NotFoundError, SyncError - Exit code verification Improved ids.test.ts: - Edge cases for normalizeIssueId (corrupted IDs, short IDs) - formatDisplayId tests Coverage improvements (vitest-only): - errors.ts: 25% → 100% - ids.ts: 78% → 100% - git.ts: 0% → 62% (merge algorithm)
jlevy
pushed a commit
that referenced
this pull request
Jan 17, 2026
Merged Beads vs tbd comparison into main review document. Now includes: Bugs (6 total): - #1: Exit codes return 0 on errors (CRITICAL) - #2: Dependency direction semantics confusing - #3: Search outputs message with --quiet - #4: Doctor warns on empty issues dir - #5: Import changes ID prefix - #6: Errors not JSON with --json flag Enhancements (20 total): - Critical (3): exit codes, npm publish, git version check - High (5): dep semantics, error JSON, tests, docs, import prefix - Medium (7): brief flag, templates, query DSL, batch ops, etc. - Low (5): history, GitHub sync, plugins, index, auto-links Key finding: tbd's single session protocol is better than Beads' 5 conditional protocols. Keep it simple.
jlevy
pushed a commit
that referenced
this pull request
May 7, 2026
The user pointed out the new Design Principles in the docs-config plan should be cross-referenced and consolidated with the existing tbd-design principles. Three changes: 1. tbd-design.md §1.5 (Design Principles) extended from 6 to 10: - #1 (Simplicity first) extended to spell out "simple things simple, complex things possible". - #3 (Git for sync) extended with the reproducible-from-config contract. - #7 added: Auth is always out-of-band — tbd never holds credentials. - #8 added: Hard cuts on format versions with reliable migration — already practiced for f02→f03; making it an explicit principle. - #9 added: Spec ↔ implementation synchrony via tests. - #10 added: Layered architecture, separable artifacts. These four new principles emerged from the docs-config redesign work but apply tbd-wide. 2. tbd-design.md §1.4 Design Goals: added goal #8 (extensible knowledge subsystem), which links forward to the plan-spec and the docref/ docmap design docs as the authoritative location for that subsystem's design. 3. plan-spec Design Principles intro: now explicitly notes that P1, P5, P6, P7, P8, P9 are restatements/elaborations of tbd-design §1.5 principles, while P2, P3, P4 are docs/config-specific and have no direct system-wide analog. Each restated principle gets an inline "(extends tbd-design §1.5 #N)" cross-reference. tbd-design.md is declared authoritative for system-wide values. This consolidates principles in one foundational location (tbd-design.md) while keeping the docs-config plan readable on its own. https://claude.ai/code/session_01PhbYdWX7DUBpUBVuUesVuP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shortcut:*.mdfiles toshortcut-*.mdformat using speculate-cli update:) are not allowed in filenames on Windows, which was causing CI failuresTest plan