Skip to content

feat: add option to delete previous comments #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jlhood merged 9 commits into from
Dec 20, 2019
Merged

feat: add option to delete previous comments #21

jlhood merged 9 commits into from
Dec 20, 2019

Conversation

@jogold
Copy link
Contributor

@jogold jogold commented Dec 12, 2019

For PR with lots of commits/builds this avoids bloating the comments which can
make review difficult.

@jlhood
Copy link
Owner

jlhood commented Dec 12, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
feat: add option to delete previous comment
31f1fb2 
For PR with lots of commits/builds this avoids bloating the comments which can
make review difficult.
@jlhood
Copy link
Owner

jlhood commented Dec 12, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jlhood
Copy link
Owner

jlhood commented Dec 12, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jlhood
jlhood requested changes Dec 13, 2019
View reviewed changes
Copy link
Owner

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Have some comments that need to be addressed but definitely supportive of adding this capability. 😊

@jogold @jlhood
type casting within config.py
edf1d57 
Co-Authored-By: James Hood <james@jlhood.com>
@jlhood
Copy link
Owner

jlhood commented Dec 13, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jlhood
Copy link
Owner

jlhood commented Dec 13, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold changed the title feat: add option to delete previous comment feat: add option to delete previous comments Dec 13, 2019
@jlhood
Copy link
Owner

jlhood commented Dec 13, 2019

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jlhood
Copy link
Owner

jlhood commented Dec 13, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jlhood
Copy link
Owner

jlhood commented Dec 16, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Dec 19, 2019

Hey @jlhood, any chance to get this reviewed?

Thanks!

jlhood
jlhood requested changes Dec 20, 2019
View reviewed changes
Copy link
Owner

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay. Thanks for addressing my feedback! A few more changes and this should be good to go!

@jlhood
Copy link
Owner

jlhood commented Dec 20, 2019

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jlhood
jlhood approved these changes Dec 20, 2019
View reviewed changes
Copy link
Owner

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Appreciate you iterating on this!

@jlhood jlhood merged commit 0d6531c into jlhood:master Dec 20, 2019
@jogold jogold mentioned this pull request Dec 23, 2019
Closed
@jogold jogold deleted the delete-previous branch January 3, 2020 09:04
jogold added a commit to jogold/aws-delivlib that referenced this pull request Apr 18, 2020
@jogold
feat(auto-build): delete previous links to build logs
ea568a2 
Delete previously published links to build logs before posting a new one
in GitHub the PR discussion. This avoids bloating PR comments which can
make review difficult.

See jlhood/github-codebuild-logs#21 and
aws/aws-cdk#5522.
jogold added a commit to jogold/aws-delivlib that referenced this pull request Apr 18, 2020
@jogold
feat(auto-build): delete previous links to build logs
fa4b89b 
Delete previously published links to build logs before posting a new one
in the GitHub PR discussion. This avoids bloating PR comments which can
make review difficult.

See jlhood/github-codebuild-logs#21 and
aws/aws-cdk#5522.
@jogold jogold mentioned this pull request Apr 18, 2020
Merged
eladb pushed a commit to cdklabs/aws-delivlib that referenced this pull request Jun 7, 2020
@jogold
feat(auto-build): delete previous links to build logs (#301)
6607d6a 
Delete previously published links to build logs before posting a new one
in the GitHub PR discussion. This avoids bloating PR comments which can
make review difficult.

See jlhood/github-codebuild-logs#21 and
aws/aws-cdk#5522.

Co-authored-by: Elad Ben-Israel <benisrae@amazon.com>
@trivikr trivikr mentioned this pull request Jan 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlhood jlhood jlhood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jogold @jlhood