AnsiConsole should fail on repeated uninstalls #1525
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the installed counter can end up negative, breaking future install attempts. I considered just ignoring repeated uninstall calls, but that may hide bugs in clients of this library, so I'd rather fail cleanly. Signed-off-by: Stefan Oehme <st.oehme@gmail.com>
gnodet
changed the title
Member
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
gnodet
pushed a commit
that referenced
this pull request
Dec 11, 2025
Otherwise, the installed counter can end up negative, breaking future install attempts. I considered just ignoring repeated uninstall calls, but that may hide bugs in clients of this library, so I'd rather fail cleanly. Signed-off-by: Stefan Oehme <st.oehme@gmail.com> (cherry picked from commit b3434b9)
Member
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
that referenced
this pull request
Dec 11, 2025
Otherwise, the installed counter can end up negative, breaking future install attempts. I considered just ignoring repeated uninstall calls, but that may hide bugs in clients of this library, so I'd rather fail cleanly. (cherry picked from commit b3434b9) Signed-off-by: Stefan Oehme <st.oehme@gmail.com> Co-authored-by: Stefan Oehme <st.oehme@gmail.com>
Contributor
Author
|
Thanks! Could you add update maven-core to use this patch? That might help me hunt down that weird race condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the installed counter can end up negative, breaking future install attempts. I considered just ignoring repeated uninstall calls, but that may hide bugs in clients of this library, so I'd rather fail cleanly.