Fix critical bugs and update type cast guidance#53
Merged
Conversation
- Initialize pluginResults in store to prevent crash if plugin calls setState during setup - Encode dynamic params in routes to prevent URL injection (/, ?, #) - Update AGENTS.md to clarify internal type casts are acceptable when consumer API remains type-safe Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryFixed two critical race condition and URL injection bugs, and clarified type safety documentation.
Both bug fixes are solid and address real production issues. The documentation update provides helpful guidance aligned with the fixes. Confidence Score: 5/5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed two critical bugs found during code review and updated documentation on type safety practices.
pluginResultsto prevent crash if plugin callssetStateduring initializationAll existing tests pass.
🤖 Generated with Claude Code