Add macro interface @bitflagx to scope definitions to a module
#15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmert
force-pushed
the
jw/scoped_bitflags
branch
from
07c8e22 to
a52ba21
Compare
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 155 190 +35
=========================================
+ Hits 155 190 +35
|
Extend the capability of the expression generator to wrap the resulting definitions within a `baremodule`, thereby introducing a scope to isolate flag value names. This requires some mild rewiring of the macro expansion to "flip" the interpretation of the name in `BitFlagName::BaseType` to instead become the module name, and a new optional first argument adds support for choosing the actual type name (defaulting to `T`) within the module. Fixes #13.
jmert
force-pushed
the
jw/scoped_bitflags
branch
from
a52ba21 to
6cf32a0
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the capability of the expression generator to wrap the resulting definitions within a
baremodule, thereby introducing a scope to isolate flag value names.This requires some mild rewiring of the macro expansion to "flip" the interpretation of the name in
BitFlagName::BaseTypeto instead become the module name, and a new optional first argument adds support for choosing the actual type name (defaulting toT) within the module.Fixes #13.