Skip to content

tweaking the interface for carves and simplifying logic a bit #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2019
Merged

tweaking the interface for carves and simplifying logic a bit #3

merged 1 commit into from
Aug 27, 2019

Conversation

ryandeivert
Copy link
Contributor

to @javuto

  • Removing the duplicative logic related to error checking in a few functions.
  • Creating a CarveResult struct to substitute the previous map that was being used and additionally simplifying the Archive logic a bit.
  • Updating the calling code to correspond to the above changes.

@javuto javuto added this to the 0.1.6 milestone Aug 27, 2019
@javuto javuto added the ✨ enhancement New feature or request label Aug 27, 2019
@javuto
Copy link
Collaborator

javuto commented Aug 27, 2019

Awesome! Thanks a lot for the pull request @ryandeivert!

@javuto javuto merged commit fb16c9a into jmpsec:master Aug 27, 2019
CptOfEvilMinions added a commit that referenced this pull request Dec 28, 2021
@CptOfEvilMinions
Merge pull request #3 from CptOfEvilMinions/initial-cicd
c9bf7f2 
Update build cmd
javuto pushed a commit that referenced this pull request Oct 9, 2024
@saryani
Add kafka backend (#3)
29bcc4c 
* fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

✨ enhancement New feature or request

Projects

None yet

Milestone

0.1.6

Development

Successfully merging this pull request may close these issues.

2 participants

@ryandeivert @javuto