Refactor for TLS handlers #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
refactor
pmoody-
reviewed
Mar 26, 2020
| }() | ||
|
|
||
| // multiple listeners channel | ||
| finish := make(chan bool) |
There was a problem hiding this comment.
Hmmm I had this from a long time ago when I was running all services in the same binary, but now I am not using it anymore. Remove!
Comment on lines
+22
to
+27
| l.Log( | ||
| logType, | ||
| data, | ||
| environment, | ||
| uuid, | ||
| debug) |
Comment on lines
+30
to
+31
| err := l.Nodes.RefreshLastStatus(uuid) | ||
| if err != nil { |
There was a problem hiding this comment.
if err := l.Nodes.RefreshLastStatus(uuid); err != nil {
}
Comment on lines
+58
to
+65
| l.QueryLog( | ||
| types.QueryLog, | ||
| data, | ||
| node.Environment, | ||
| node.UUID, | ||
| queryData.Name, | ||
| queryData.Status, | ||
| debug) |
Comment on lines
+15
to
+16
| err := json.Unmarshal(data, &logs) | ||
| if err != nil { |
| result := []string{} | ||
| for _, entry := range duplicated { | ||
| if _, value := keys[entry]; !value { | ||
| keys[entry] = true |
There was a problem hiding this comment.
i don't think you actually need this. you don't use it anywhere.
CptOfEvilMinions
added a commit
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview