Fix for create_release GHA when tagged #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javuto
added
📦 build
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the GitHub Actions workflow for creating tagged releases by correcting the release version tag reference and adjusting the job conditions and package handling.
- Fixes the
release_version_tagparameter to use the correct variableRELEASE_VERSIONinstead ofbranch - Adds conditional execution for the
create_releasejob to only run on tag pushes - Improves DEB package handling by making download optional and expanding OS support
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/create_tagged_releases.yml |
Updates release version tag variable, adds tag condition, and expands OS matrix |
.github/actions/tagged_release/github/action.yml |
Makes DEB package download optional and improves step naming |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tagging a release, the job
create_releasewas failing due to the push to themainbranch, and DEB packages being missing.