Skip to content

Conversation

javuto
Copy link
Collaborator

@javuto javuto commented Sep 18, 2025

Implementing #529 and #682 and add the ability to run on-demand queries and file carves by tags.

@javuto javuto requested a review from Copilot September 18, 2025 18:48
@javuto javuto added osctrl-admin osctrl-admin related changes queries On-demand queries related issues carves File carving related issues labels Sep 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements query and carve functionality based on tags in osctrl-admin, adding support for targeting nodes by tags in on-demand queries and file carves. The implementation enhances the existing targeting system to include tag-based selection alongside environment, platform, UUID, and hostname targeting.

Key Changes:

  • Added tag support to the API request structures and query/carve forms
  • Implemented tag-based node selection logic for both queries and carves
  • Enhanced UI to include tag selection dropdown in query and carve interfaces

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pkg/types/types.go Added Tags field to ApiDistributedQueryRequest structure
pkg/tags/utils.go Added helper functions for tag string conversions and tag name extraction
pkg/tags/utils_test.go Added test for GetStrTagName function
pkg/tags/tags.go Added GetTaggedNodes method to retrieve nodes by tag
pkg/queries/queries.go Updated Create method signature and added Target field to DistributedQuery
pkg/nodes/nodes.go Refactored node retrieval methods and improved error messages
cmd/admin/handlers/ Updated query/carve handlers to support tag targeting and refactored target parsing
cmd/admin/templates/ Enhanced UI templates to include tag selection and improved styling
cmd/admin/static/js/ Updated JavaScript to handle tag selections in forms

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@javuto javuto merged commit fb403fd into main Sep 19, 2025
55 checks passed
@javuto javuto deleted the query-with-tags branch September 19, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

carves File carving related issues osctrl-admin osctrl-admin related changes queries On-demand queries related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant