Skip to content

Conversation

javuto
Copy link
Collaborator

@javuto javuto commented Sep 19, 2025

Implementing #529 and #682 and add the ability to run on-demand queries and file carves by tags.

@javuto javuto requested a review from Copilot September 19, 2025 22:50
@javuto javuto added osctrl-api osctrl-api related changes osctrl-cli osctrl-cli related changes queries On-demand queries related issues carves File carving related issues labels Sep 19, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements query and carve functionality based on tags in both osctrl-api and osctrl-cli components. It refactors the existing node targeting logic by creating a centralized handler package that supports multiple targeting methods including tags, platforms, hostnames, and UUIDs.

Key changes include:

  • Centralized query/carve creation logic in a new handlers package
  • Extended CLI support for multiple targeting options with comma-separated values
  • Unified API request structure by consolidating separate carve and query request types

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pkg/handlers/handlers.go New centralized handler for query/carve creation with multi-target support
pkg/utils/utils.go Added utility functions for slice intersection and string containment checks
pkg/types/types.go Consolidated API request types by merging carve and query structures
pkg/nodes/nodes.go Added environment-scoped node retrieval method
cmd/cli/*.go Extended CLI commands to support multiple targeting options with comma-separated values
cmd/api/handlers/*.go Refactored to use centralized handlers and unified request types
cmd/admin/handlers/*.go Updated to use new centralized handler logic and consolidated request types

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@javuto javuto merged commit a4a8acf into main Sep 20, 2025
55 checks passed
@javuto javuto deleted the tags-query-api branch September 20, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

carves File carving related issues osctrl-api osctrl-api related changes osctrl-cli osctrl-cli related changes queries On-demand queries related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant