Fix newly-created profile reappearing after restart when deleted#83
Merged
Conversation
A profile created via "New Profile" in MMLaunch holds an empty ProfileKeyName in memory. Picking an EXE triggers RegConfig.saveProfile, which lazily creates a registry subkey (e.g. Profile0000) but discarded its name via `ignore`, so the in-memory RunConfig stayed unsynced. The delete handler skipped RegConfig.removeProfile because ProfileKeyName was still "", leaving the orphan subkey to be re-enumerated by loadAll on next launch. saveProfile now returns the updated RunConfig with ProfileKeyName set to the bare subkey name, and ProfileModel.save assigns it back to its mutable config. This keeps in-memory state consistent with the registry so the existing delete guard works on the first try.
Owner
Author
|
Fixes #3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A profile created via "New Profile" in MMLaunch holds an empty ProfileKeyName in memory. Picking an EXE triggers RegConfig.saveProfile, which lazily creates a registry subkey (e.g. Profile0000) but discarded its name via
ignore, so the in-memory RunConfig stayed unsynced. The delete handler skipped RegConfig.removeProfile because ProfileKeyName was still "", leaving the orphan subkey to be re-enumerated by loadAll on next launch.saveProfile now returns the updated RunConfig with ProfileKeyName set to the bare subkey name, and ProfileModel.save assigns it back to its mutable config. This keeps in-memory state consistent with the registry so the existing delete guard works on the first try.