feat: stream multipart file uploads to reduce memory usage #829
+469
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The issue was in
Request::Body#generate_multipartwhich:file.read<<Solution
Introduced
StreamingMultipartBodyclass that implements an IO-like interface (read,size,rewind) which Net::HTTP can use viabody_stream. Files are read in chunks on-demand instead of being loaded entirely into memory.Changes
lib/httparty/request/streaming_multipart_body.rblib/httparty/request/body.rbstreaming?,to_stream,prepared_partslib/httparty/request.rbbody_streamfor file uploadsUsage
Streaming is automatic for file uploads. To opt-out:
Test plan
StreamingMultipartBody(read, size, rewind, chunking)Body#streaming?andBody#to_streambody_streamis used for file uploadsFixes issue reported in: https://gist.github.com/janko/238bbcc78b369ce3438365e5507bc671
🤖 Generated with Claude Code