fix(release): bump sqlrite-journal example in bump-version.sh (unblocks 0.11.0)#152
Merged
Conversation
The `sqlrite-journal` desktop example (examples/desktop-journal/src-tauri) is a workspace member that pins `sqlrite-engine` via a path+version dep, but it was never added to bump-version.sh's file lists. Patch releases survived because its `^0.10.1` pin still matched `0.10.x`, but the first minor bump (0.11.0) falls outside `^0.10.1`, so the Release-PR workflow's workspace lock refresh failed: error: failed to select a version for the requirement `sqlrite-engine = "^0.10.1"` … required by package `sqlrite-journal` (release-pr run 26737256013, dispatching v0.11.0.) Add it to TOML_FILES so both its package version and its engine dep pin track every bump — the same full-bump treatment desktop/src-tauri already gets. Verified locally: `bump-version.sh 0.11.0` now rewrites the journal manifest and `cargo build --workspace --exclude sqlrite-desktop --exclude sqlrite-journal` (the exact CI lock-refresh step) resolves cleanly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dispatching the Release PR workflow for
0.11.0failed at the "Refresh Cargo.lock" step (release-pr run 26737256013):Root cause
examples/desktop-journal/src-tauri/Cargo.toml(sqlrite-journal, the SQLR-43 concurrent-writes journal example) is a workspace member that pins the engine via a path+version dep:…but it was never added to
bump-version.sh's file lists. Every prior release was a patch bump, and^0.10.1still matched0.10.2/0.10.3, so the stale pin resolved fine.0.11.0is the first minor bump — it falls outside^0.10.1, so the whole-workspace lock refresh can't select a version. The existing--exclude sqlrite-journal(eb4662c) only skips building it; cargo still resolves the full workspace graph for the lockfile.Fix
Add the journal manifest to
TOML_FILES— the same full-bump treatment the siblingdesktop/src-tauriTauri app already gets. The existing sweep then rewrites both its package version and its engine dep pin on every bump, so the pin can never lag the engine again (patch or minor).Verification (local, in a worktree)
bash scripts/bump-version.sh 0.11.0→ journal manifest now showsversion = "0.11.0"andsqlrite-engine … version = "0.11.0"; the script's own verification loop passes.cargo build --workspace --exclude sqlrite-desktop --exclude sqlrite-journal(the exact CI lock-refresh command) resolves cleanly;Cargo.locklandssqlrite-engine 0.11.0.After merge
Re-dispatch
release-pr.ymlwith0.11.0to open the (now-passing) Release PR.🤖 Generated with Claude Code