release.yml: accept GitHub squash-merge (#N) suffix in detect regex#19
Merged
release.yml: accept GitHub squash-merge (#N) suffix in detect regex#19
Conversation
GitHub's default squash-merge title is `<PR title> (#N)` — so merging a Release PR titled `release: v0.1.2` lands on main as `release: v0.1.2 (#18)`, which the old anchored regex rejected. The v0.1.2 canary had to be kicked via workflow_dispatch as a result. Strip the trailing ` (#N)` before the regex test so both forms match. Editing the title to drop the suffix still works; it just isn't required anymore. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub's default squash-merge title is
<PR title> (#N). So when a Release PR titledrelease: v0.1.2gets squash-merged, the commit on main isrelease: v0.1.2 (#18). The old anchored regex ($at the end) rejected that, and the workflow silently no-op'd.That just happened on the v0.1.2 canary — had to kick
release.ymlviaworkflow_dispatchas a manual workaround. This fixes it so future canaries detect + publish automatically.What changes
.github/workflows/release.yml: strip trailing(#N)from the commit subject before the regex test.Editing the squash-merge title to drop the suffix still works; it just isn't required anymore.
Test plan
🤖 Generated with Claude Code