Conversation
Bumps every product manifest from 0.2.0 → 0.3.0 (engine, sqlrite-ask, sqlrite-ffi, sqlrite-mcp, four SDK crates, desktop, Tauri config) and the three inter-workspace dependency pins that `bump-version.sh` currently misses (engine→sqlrite-ask, sqlrite-mcp→engine, wasm SDK→sqlrite-ask). Refreshes Cargo.lock. Headline change: PR #86 (SQLR-2) added DEFAULT clause on CREATE TABLE columns, DROP TABLE / DROP INDEX with IF EXISTS, and ALTER TABLE with the four SQLite-style sub-operations (RENAME TO, RENAME COLUMN, ADD COLUMN, DROP COLUMN). Note: the release-pr.yml workflow's bump step failed with `failed to select a version for the requirement \`sqlrite-ask = "^0.2"\`` because bump-version.sh doesn't update inter-workspace path-dep version specs. Filing a follow-up to fix the script; for this release the three pins were patched manually. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
joaoh82
added a commit
that referenced
this pull request
May 4, 2026
…-9) (#88) * fix(release): bump-version.sh rewrites inter-workspace dep pins (SQLR-9) The release-pr.yml dispatch for v0.3.0 failed at `cargo build` with `failed to select a version for the requirement sqlrite-ask = "^0.2"` because bump-version.sh updated the package-level `version = "X.Y.Z"` field in 11 manifests but ignored the three `version = "..."` pins that workspace crates declare on each other (engine→sqlrite-ask, sqlrite-mcp→engine, wasm SDK→sqlrite-ask). PR #87 patched those by hand; this change makes the script handle them automatically. Approach: detect any TOML line containing both `version = "..."` and `path = "..."`, rewrite the version to the full bumped semver. This is unambiguous in the repo (no false positives) and handles both inline-table orderings. Future workspace crates added with the same path+version shape get rewritten with no script changes. The rewrite uses the full X.Y.Z[-pre][+build] form (e.g. "0.3.0", not "0.3"), which catches drift inside a minor and works with the prerelease-dispatch path. Visible effect on the next release PR: the three pins flip from "0.3" to "0.3.0". Also extends the verify loop to flag any surviving same-line `path = ... version = ...` pin not at the bumped version, so a future refactor that changes pin shape (e.g. multi-line deps) fails loudly instead of silently producing a broken release branch. Verification: - bump-version.sh 9.9.9-test rewrites all three pins (both inline-table orderings). - Re-running with the same arg is byte-exact idempotent. - `cargo build --workspace --exclude sqlrite-desktop ...` resolves cleanly — the original SQLR-9 failure mode no longer reproduces. - Verify-loop logic confirmed against a staled-pin fixture. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(release): fix off-by-one file counts in bump-version.sh banner The header docstring said "eight Cargo.toml / pyproject.toml files, plus three JSON manifests — eleven files total" and the footer said "the ten-file bump". TOML_FILES has nine entries (root engine, ffi, ask, mcp, python ×2, nodejs, wasm, desktop) plus three JSON manifests = twelve total. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps every product manifest from 0.2.0 → 0.3.0 and refreshes
Cargo.lock.Headline change: #86 (SQLR-2) added the DEFAULT clause on CREATE TABLE columns, DROP TABLE / DROP INDEX with IF EXISTS, and ALTER TABLE with the four SQLite-style sub-operations (RENAME TO, RENAME COLUMN, ADD COLUMN, DROP COLUMN). Minor bump (new SQL surface, no breaking changes).
Files touched
scripts/bump-version.sh 0.3.0Cargo.lockrefreshedNote on the release workflow
The
release-pr.ymlworkflow failed at thecargo buildstep:scripts/bump-version.shupdates the package-levelversion = "X.Y.Z"field in every manifest, but doesn't update the inter-workspace dependency version specs that other workspace members declare on each other:Cargo.toml:141—sqlrite-ask = { version = "0.2", ... }sqlrite-mcp/Cargo.toml:55—sqlrite-engine = { version = "0.2", ... }sdk/wasm/Cargo.toml:49—sqlrite-ask = { version = "0.2", ... }These were patched manually for this release. Filing a follow-up to fix the script so the next release goes through the workflow cleanly.
Test plan
🤖 Generated with Claude Code