Fix default color on dark theme#3
Merged
joaomoreno merged 1 commit intojoaomoreno:masterfrom Mar 30, 2020
zackkrida:patch-1
Merged
Fix default color on dark theme#3joaomoreno merged 1 commit intojoaomoreno:masterfrom zackkrida:patch-1
joaomoreno merged 1 commit intojoaomoreno:masterfrom
zackkrida:patch-1
Conversation
The default color on the dark theme is broken; this fixes it!
|
Thanks dude, today I entered this repo to see how to fix that and found your PR! 👍 |
Owner
|
Thanks! |
Owner
|
Published 1.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default color on the dark theme is broken; this fixes it! Here's an example of some JavaScript and some SQL code:
Before:

After:

Fixes issue thenikso#15 which was placed on the wrong repo. For anyone who wants to fix this locally, you can add the following to your vscode settings json file:
{ "editor.tokenColorCustomizations": { "[GitHub Sharp Dark]": { "textMateRules": [ { "scope": [ "keyword.operator.accessor", "meta.group.braces.round.function.arguments", "meta.template.expression", "markup.fenced_code meta.embedded.block" ], "settings": { "foreground": "#c3c6c9" } }, ] }, } }