Skip to content

Fix default color on dark theme#3

Merged
joaomoreno merged 1 commit intojoaomoreno:masterfrom
zackkrida:patch-1
Mar 30, 2020
Merged

Fix default color on dark theme#3
joaomoreno merged 1 commit intojoaomoreno:masterfrom
zackkrida:patch-1

Conversation

@zackkrida
Copy link
Copy Markdown

The default color on the dark theme is broken; this fixes it! Here's an example of some JavaScript and some SQL code:

Before:
Screen Shot 2020-03-20 at 15 00 43

After:
Screen Shot 2020-03-20 at 15 00 22

Fixes issue thenikso#15 which was placed on the wrong repo. For anyone who wants to fix this locally, you can add the following to your vscode settings json file:

{
 "editor.tokenColorCustomizations": {
    "[GitHub Sharp Dark]": {
      "textMateRules": [
        {
          "scope": [
            "keyword.operator.accessor",
            "meta.group.braces.round.function.arguments",
            "meta.template.expression",
            "markup.fenced_code meta.embedded.block"
          ],
          "settings": {
            "foreground": "#c3c6c9"
          }
        },
      ]
    },
  }
}

The default color on the dark theme is broken; this fixes it!
@joadr
Copy link
Copy Markdown

joadr commented Mar 24, 2020

Thanks dude, today I entered this repo to see how to fix that and found your PR! 👍

@joaomoreno joaomoreno merged commit 4b02fee into joaomoreno:master Mar 30, 2020
@joaomoreno
Copy link
Copy Markdown
Owner

Thanks!

@joaomoreno
Copy link
Copy Markdown
Owner

Published 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants