Fix bad dialog instantiation#2108
Merged
Merged
Conversation
Fixes a bug where the edit feed dialog was instantiated on each feed row such that the resulting feed allocations totaled O(N^2) which reliably caused an OutOfMemory exception. For an account with 175 feeds, this resulted in ~30k feed allocations (175^2). The fix is to only construct the dialog when it's opened.
jocmp
force-pushed
the
jc/2089/miniflux-bug
branch
from
4ae6b57 to
bbab327
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the edit feed dialog was instantiated on each feed row such that the resulting feed allocations totaled O(N^2) which reliably caused an OutOfMemory exception.
For an account with 175 feeds, this resulted in ~30k feed allocations (175^2).
The fix is to only construct the dialog when it's opened.
Ref