Skip to content

Correct nets_date converter #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sondrelg merged 4 commits into from
Aug 25, 2022
Merged

Correct nets_date converter #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5835b51
fix: Replace date converter to allow none
sondrelg Aug 25, 2022
a6a3667
chore: Update pre-commit hooks
sondrelg Aug 25, 2022
3ef46dd
chore: Update lockfile
sondrelg Aug 25, 2022
3a6e6d1
chore: Fix linting errors
sondrelg Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
repos:
- repo: https://github.com/psf/black
rev: 22.3.0
rev: 22.6.0
hooks:
- id: black
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.2.0
rev: v4.3.0
hooks:
- id: check-ast
- id: check-added-large-files
Expand Down Expand Up @@ -34,7 +34,7 @@ repos:
'flake8-type-checking',
]
- repo: https://github.com/asottile/pyupgrade
rev: v2.32.0
rev: v2.37.3
hooks:
- id: pyupgrade
args: [ "--py36-plus", "--py3-plus", "--py37-plus" ]
Expand All @@ -43,7 +43,7 @@ repos:
hooks:
- id: isort
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.950
rev: v0.971
hooks:
- id: mypy
args:
Expand Down
1 change: 0 additions & 1 deletion netsgiro/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ def _add_avtalegiro_transaction(
payer_name: Optional[str] = None,
bank_notification: Union[str, bool] = False,
) -> 'PaymentRequest':

text = bank_notification if isinstance(bank_notification, str) else ''
number = self._next_transaction_number
self._next_transaction_number += 1
Expand Down
4 changes: 2 additions & 2 deletions netsgiro/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class TransmissionEnd(Record):
num_transactions: int = field(converter=int)
num_records: int = field(converter=int)
total_amount: int = field(converter=int)
nets_date: 'datetime.date' = field(converter=to_date)
nets_date: 'datetime.date' = field(converter=to_date_or_none)

RECORD_TYPE: ClassVar[RecordType] = RecordType.TRANSMISSION_END
_PATTERNS: ClassVar[List[Pattern]] = [
Expand Down Expand Up @@ -366,7 +366,7 @@ def to_ocr(self) -> str:


@define
class TransactionRecord(Record, ABC):
class TransactionRecord(Record):
"""Transaction record base class."""

transaction_type: 'TransactionType' = field(converter=to_transaction_type)
Expand Down
Loading