ADR-147: Add ProgramDelegate support to CommandServiceBase#103
Merged
jodavis merged 2 commits intodev/jodavis/ADR-128-spec-programmable-ir-commandsfrom Feb 26, 2026
Conversation
Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement task ADR-147 with unit tests for edge cases
ADR-147: Add ProgramDelegate support to CommandServiceBase
Feb 26, 2026
jodavis
approved these changes
Feb 26, 2026
jodavis
added a commit
that referenced
this pull request
Feb 27, 2026
* ADR-147: Add ProgramDelegate support to CommandServiceBase --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>
jodavis
added a commit
that referenced
this pull request
Mar 11, 2026
* ADR-147: Add ProgramDelegate support to CommandServiceBase --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jodavis <6740581+jodavis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends
CommandServiceBase<T>andCommandto support an optionalProgramDelegateaction for IR command learning, with the same error handling, logging, and UI state lifecycle asExecuteDelegate. Services that don't support programming returnnullfromCreateProgramHandler()and are unaffected.Model
Command: AddedProgramAsync(ExecuteDelegate?) property with MVVM support.nullmeans "not programmable."CommandServiceBase
CreateProgramHandler(CommandType): newvirtualmethod, returnsnullby default; override to enable programmingInitializeAsync: callsCreateProgramHandlerper command; wraps non-null results and setscommand.ProgramAsync, tracks programmable commandsCleanUpAsync: sets a "was shut down" handler on programmable commands (consistent withExecuteAsyncbehavior); non-programmable commands staynullCreateWrappedProgramHandler: mirrors execute wrapper — setsIsActive, logs start/success/cancel/error, propagates exceptionsLogging & Errors
MessageLoggerentries (EventIds 607–611):Programming,Programmed,ProgramError,ProgramCancelled,ProgramWasShutDownErrors.CommandService_ProgramWasShutDownfor post-shutdown callsTests
MockProgrammableCommandServicetest double overrides bothCreateHandlerandCreateProgramHandlerIsActivelifecycle; success, long-running (viaTaskCompletionSource), error, and cancellation paths; cancellation token propagation; and shutdown handler behavior💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.