fix bug completing functions #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function did not complete with a SELECT * FROM TAB1 WHERE func1 it did work for cases where the columns are declared in the select SELECT a,b FROM TAB1 WHERE func1 it now works with select star also
Contributor
Author
|
hey @joe-re hope all is well. Wondering if you could give this a review and make a new release for vscode. We're hoping to use the latest version soon. Thanks. |
Owner
|
@cccs-jc Hi, thanks for your PR and sorry it's been a while it's not been released. I'll handle that ASAP, thanks. 🙏 |
Contributor
Author
|
Great, thanks @joe-re |
joe-re
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
function did not complete with a
SELECT * FROM TAB1 WHERE func1
it did work for cases where the columns are declared in the select
SELECT a,b FROM TAB1 WHERE func1
it now works with select star also