Skip to content

properly remove entire fermenter and reformer#54

Merged
joe7575 merged 3 commits intojoe7575:masterfrom
fluxionary:multiblock_dig_fix
Aug 23, 2020
Merged

properly remove entire fermenter and reformer#54
joe7575 merged 3 commits intojoe7575:masterfrom
fluxionary:multiblock_dig_fix

Conversation

@fluxionary
Copy link
Contributor

@fluxionary fluxionary commented Aug 22, 2020

after checking that they don't have contents.

add an LBM to remove top parts of the machines stranded by the current bug.

…y don't have contents; add an LBM to remove stranded top nodes
@fluxionary
Copy link
Contributor Author

Hold on before merging, it also needs to check for protection too. Working on that now.

@fluxionary
Copy link
Contributor Author

OK, seems to be working fine for me now.

However, I'm unsure whether the logic for removing the defective variants needs to call State:on_dig_node and tubelib.remove_node instead of minetest.node_dig (and this applies to single-node machines as well).

@joe7575
Copy link
Owner

joe7575 commented Aug 23, 2020

You are right, the already defect node should not call State:on_dig_node (in order to possibly get defect again).
Good work, thanks.

@joe7575 joe7575 merged commit 1175301 into joe7575:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants