Suggestion to check replanting against commonly plantable nodes instead of quarry-able GroundNodes#60
Merged
joe7575 merged 1 commit intojoe7575:masterfrom Dec 14, 2020
Merged
Conversation
…ad of quarry-able GroundNodes
Owner
|
I like the solution a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BLS issue 265 BlockySurvival/issue-tracker#265
This is a suggestion, and I do not believe the behaviour is a bug, since it doesn't have any real negative effects, is rarely encountered, and can easily be worked around
This PR does not check the
tubelib1.GroundNodestable for nodes when deciding weather or not to replant a tree / flower / crop, instead it checks if the node is ingroup:soilorgroup:sand(for palm trees).Checking these groups should cover most cases, while not also allowing saplings to be replanted on other quarry-able ground nodes, like stone, ores, and clay