Skip to content

fix crash#89

Closed
superfloh247 wants to merge 1 commit intojoe7575:masterfrom
superfloh247:master
Closed

fix crash#89
superfloh247 wants to merge 1 commit intojoe7575:masterfrom
superfloh247:master

Conversation

@superfloh247
Copy link
Contributor

node IDs do no contain a space

2021-06-04 21:50:20: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'tubelib_addons1' in callback node_on_timer(): "ethereal:strawberry 1" is not a registered node!
2021-06-04 21:50:20: ERROR[Main]: stack traceback:
2021-06-04 21:50:20: ERROR[Main]: [C]: in function 'set_node'
2021-06-04 21:50:20: ERROR[Main]: ...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:177: in function 'remove_or_replace_node'
2021-06-04 21:50:20: ERROR[Main]: ...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:240: in function 'harvest_field'
2021-06-04 21:50:20: ERROR[Main]: ...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:271: in function <...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:262>

node IDs do no contain a space

2021-06-04 21:50:20: ERROR[Main]: ServerError: AsyncErr: ServerThread::run Lua: Runtime error from mod 'tubelib_addons1' in callback node_on_timer(): "ethereal:strawberry 1" is not a registered node!
2021-06-04 21:50:20: ERROR[Main]: stack traceback:
2021-06-04 21:50:20: ERROR[Main]: 	[C]: in function 'set_node'
2021-06-04 21:50:20: ERROR[Main]: 	...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:177: in function 'remove_or_replace_node'
2021-06-04 21:50:20: ERROR[Main]: 	...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:240: in function 'harvest_field'
2021-06-04 21:50:20: ERROR[Main]: 	...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:271: in function <...etest/bin/../mods/techpack/tubelib_addons1/harvester.lua:262>
@joe7575
Copy link
Owner

joe7575 commented Jun 6, 2021

I fixed it! Thanks for the report

@joe7575 joe7575 closed this Jun 6, 2021
@superfloh247
Copy link
Contributor Author

It's not fixed.
A harvester will call minetest.set_node with a node called "ethereal:strawberry 2" wich does not exist and is against naming conventions.

see

fn("ethereal:strawberry_8", "ethereal:strawberry 2", "ethereal:strawberry_1")

@superfloh247
Copy link
Contributor Author

I was too hasty. My fault.
It registers to drop two of ethereal:strawberry and plants a ethereal:strawberry_1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants