fix(frontend): npm audit fix — resolve 3 moderate transitive vulns#13
Closed
terafin wants to merge 2 commits into
Closed
fix(frontend): npm audit fix — resolve 3 moderate transitive vulns#13terafin wants to merge 2 commits into
terafin wants to merge 2 commits into
Conversation
`npm audit` was flagging 3 moderate-severity transitive vulnerabilities, breaking CI on every push: - react-router 6.7.0–6.30.3 (GHSA-2j2x-hqr9-3h42, same-origin open redirect via protocol-relative URL) - react-router-dom (depends on vulnerable react-router) - ws 8.0.0–8.20.0 (GHSA-58qx-3vcg-4xpx, uninitialized memory disclosure) `npm audit fix` resolves all three by bumping locked transitive versions in package-lock.json. No package.json semver constraints changed — these are within-range patch bumps. Verified: `npm audit` reports 0 vulnerabilities post-fix.
terafin
force-pushed
the
fix/npm-audit-react-router-ws
branch
from
0863c1f to
d4a0078
Compare
Contributor
Author
|
Hi @joeblack2k — closing this in favor of #15 to keep your queue cleaner. We had three PRs (this one, #5, #14) all trying to clear the same react-router 6.x + ws moderate npm-audit vulns — this one took the broader version-bump approach across the lockfile. #15 takes the cleaner advisory route ( Our fork (intarweb/RetroSaveManager) is already cherry-picking #15 locally via the sync-upstream workflow, so Thanks for the project! |
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`npm audit` flags 3 moderate-severity transitive vulnerabilities in `frontend/package-lock.json`:
CI was failing the `Frontend audit` step on every push to `main`.
Fix
`npm audit fix` then scrub registry URLs to canonical `registry.npmjs.org/` (my workstation has an internal npm mirror configured, which leaked into the regenerated lockfile — force-pushed a clean version, all 152 resolved URLs now point to registry.npmjs.org). No `package.json` semver constraints changed.
Verification
```
$ npm audit
found 0 vulnerabilities
```
Diff: `frontend/package-lock.json` only.
🤖 Filed by Justin's intarweb fork-republisher (CI was red on the fork; mirroring the fix upstream).