Merge pull request #735 from joecare99/dependabot/nuget/TestStatements/TestStatements/TestStatements/multi-406c4e7770#736
Merged
Merged
Conversation
--- updated-dependencies: - dependency-name: coverlet.collector dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: coverlet.collector dependency-version: 10.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
….0.6 --- updated-dependencies: - dependency-name: Microsoft.Extensions.Configuration.UserSecrets dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.Configuration.UserSecrets dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…5 to 10.0.6 --- updated-dependencies: - dependency-name: Microsoft.Extensions.DependencyInjection.Abstractions dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…s.Hosting Bumps Microsoft.Extensions.DependencyInjection from 10.0.5 to 10.0.6 Bumps Microsoft.Extensions.Hosting from 10.0.5 to 10.0.6 --- updated-dependencies: - dependency-name: Microsoft.Extensions.DependencyInjection dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.Hosting dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.DependencyInjection dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Extensions.Hosting dependency-version: 10.0.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…s/TestStatementsTest/TestStatements/multi-1634f3bb90
…s/AppWithPlugin/TestStatements/multi-b31caab35f
…ibraries/BaseLib/TestStatements/Microsoft.Extensions.DependencyInjection.Abstractions-10.0.6
…s/TestStatements/TestStatements/multi-406c4e7770
There was a problem hiding this comment.
Pull request overview
Updates NuGet dependencies across multiple projects (primarily Dependabot-driven), bumping test coverage tooling and Microsoft.Extensions patch versions.
Changes:
- Bump
coverlet.collectorfrom 8.0.1 to 10.0.0 in test projects. - Bump
Microsoft.Extensions.DependencyInjection/Microsoft.Extensions.Hostingto 10.0.6 in TestStatements projects. - Bump
Microsoft.Extensions.Configuration.UserSecretsto 10.0.6 in plugin app projects andMicrosoft.Extensions.DependencyInjection.Abstractionsto 10.0.6 in BaseLib.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TestStatements/TestStatementsTest/TestStatements_netTest.csproj | Updates coverlet.collector to 10.0.0 for net test project. |
| TestStatements/TestStatementsTest/TestStatementsTest.csproj | Updates coverlet.collector to 10.0.0 for multi-target test project. |
| TestStatements/TestStatements/TestStatements_net.csproj | Updates Microsoft.Extensions.* DI/Hosting patch versions to 10.0.6. |
| TestStatements/TestStatements/TestStatements.csproj | Updates Microsoft.Extensions.* DI/Hosting patch versions to 10.0.6. |
| TestStatements/AppWithPluginWpf/AppWithPluginWpf.csproj | Updates Microsoft.Extensions.Configuration.UserSecrets to 10.0.6. |
| TestStatements/AppWithPlugin/AppWithPlugin.csproj | Updates Microsoft.Extensions.Configuration.UserSecrets to 10.0.6. |
| CSharpBible/Libraries/BaseLib/BaseLib.csproj | Updates Microsoft.Extensions.DependencyInjection.Abstractions to 10.0.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
29
to
30
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.5" /> | ||
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.5" /> |
There was a problem hiding this comment.
This project now references Microsoft.Extensions.Configuration.UserSecrets at 10.0.6 while other Microsoft.Extensions.* packages remain at 10.0.5. Keeping these patch versions aligned (or moving versions to a central props/packages file) helps avoid NuGet downgrade/conflict warnings and makes dependency management easier.
Suggested change
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.5" /> | |
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.5" /> | |
| <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="10.0.6" /> | |
| <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="10.0.6" /> |
| <ItemGroup> | ||
| <PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.2" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.5" /> | ||
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.6" /> |
There was a problem hiding this comment.
This project now references Microsoft.Extensions.Configuration.UserSecrets at 10.0.6 while other Microsoft.Extensions.* packages remain at 10.0.5. Consider aligning the patch versions to reduce the chance of NuGet version conflict/downgrade warnings and keep dependency versions consistent.
Suggested change
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.6" /> | |
| <PackageReference Include="Microsoft.Extensions.Configuration.UserSecrets" Version="10.0.5" /> |
| @@ -31,6 +31,6 @@ | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Condition="'$(TargetFrameWork)'=='net462'" Include="System.ValueTuple" Version="4.6.2" /> | |||
There was a problem hiding this comment.
The MSBuild property in this condition is misspelled: $(TargetFrameWork) is not the standard $(TargetFramework), so this conditional System.ValueTuple reference will never apply when building the net462 target.
Suggested change
| <PackageReference Condition="'$(TargetFrameWork)'=='net462'" Include="System.ValueTuple" Version="4.6.2" /> | |
| <PackageReference Condition="'$(TargetFramework)'=='net462'" Include="System.ValueTuple" Version="4.6.2" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.