Skip to content

fix(popover): fix CdkTrapFocus issue #48#52

Merged
joejordanbrown merged 3 commits intojoejordanbrown:masterfrom
Mitra-Intelligence:fixing-trap-focus
Jun 27, 2019
Merged

fix(popover): fix CdkTrapFocus issue #48#52
joejordanbrown merged 3 commits intojoejordanbrown:masterfrom
Mitra-Intelligence:fixing-trap-focus

Conversation

@aabi01
Copy link
Copy Markdown
Contributor

@aabi01 aabi01 commented Jun 27, 2019

I have imported the 'A11yModule' module in the package. It was missing. Which caused cdkTrapFocus not to work.

@joejordanbrown
Copy link
Copy Markdown
Owner

@aabi01

Thanks for the pull request.

I was working on a similar pull request, that relates to issue #48, I just hadn't had time to push the changes yet.

I'll merge yours and push my changes to the repo too.

@joejordanbrown
Copy link
Copy Markdown
Owner

joejordanbrown commented Jun 27, 2019

LGTM

Approved with PullApprove

@joejordanbrown joejordanbrown changed the title Fixing trap focus fix(popover): fix CdkTrapFocus issue #48 Jun 27, 2019
@joejordanbrown joejordanbrown merged commit 03cd7f1 into joejordanbrown:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants