v1 UI, v3 UI: Show legacy subreddit member count, fix attaching side menu to header#195
Merged
joelacus merged 4 commits intojoelacus:devfrom Sep 28, 2025
Merged
v1 UI, v3 UI: Show legacy subreddit member count, fix attaching side menu to header#195joelacus merged 4 commits intojoelacus:devfrom
joelacus merged 4 commits intojoelacus:devfrom
Conversation
…ge and user info in header is on
joelacus
reviewed
Sep 28, 2025
| */ | ||
| function formatNumber(num) { | ||
| const units = [ | ||
| { value: 1e18, symbol: 'E' }, |
Owner
There was a problem hiding this comment.
1e18 ?! I didn't realise how big some subreddits were!
Contributor
Author
|
This is copied from the implementation of "Display page and user info in header" in `old_new_ui.js`. Feel free to remove this if you like.
… On 28 Sep 2025, at 08:53, Joelacus ***@***.***> wrote:
@joelacus commented on this pull request.
In src-webpack/src/common/content/tweaks/productivity/show_member_count.js:
> + if (text) text.textContent = formatNumber(memberCount.toString(10));
+ if (header.getAttribute('subscribers-text') === '') {
+ header.setAttribute('subscribers-text', 'Members');
+ }
+ header.removeAttribute('weekly-contributions');
+}
+
+/**
+ * Format numbers to short form, e.g. 1500 to 1.5k.
+ *
+ * @param num
+ * @returns {string|string}
+ */
+function formatNumber(num) {
+ const units = [
+ { value: 1e18, symbol: 'E' },
1e18 ?! I didn't realise how big some subreddits were!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reddit changes
Problem with Firefox Multi-Account Container? Sort order ignored. #191