Merged
Conversation
we have a lot of tests that depend on the exact layout of the tables, e.g. see https://ci.shiftleftsecurity.com/blue/organizations/jenkins/CI-PR-CODESCIENCE-pr.Jenkinsfile/detail/CI-PR-CODESCIENCE-pr.Jenkinsfile/10852/tests note: that's a blind fix. I haven't actually pulled this all the way up the dependency chain to verify that's the only inadvertent change we want to avoid.
Contributor
Author
|
Fixed some more bugs: The available width was taken as a max width per column instead of for the whole table. |
maltek
changed the title
Contributor
Author
|
I have tested with downstream now. We still have some failed tests, because the line breaking when the max width is exceeded works better now. I'd say that's worth it and we should adjust the affected tests. |
mpollmeier
approved these changes
Mar 11, 2026
Contributor
|
started the release workflow: https://github.com/joernio/flatgraph/actions/runs/22957684345 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we have a lot of tests that depend on the exact layout of the tables, e.g. see https://ci.shiftleftsecurity.com/blue/organizations/jenkins/CI-PR-CODESCIENCE-pr.Jenkinsfile/detail/CI-PR-CODESCIENCE-pr.Jenkinsfile/10852/tests