Skip to content

chore(repo): fix all oxlint errors and warnings#160

Merged
zrosenbauer merged 6 commits intomainfrom
chore/fix-lint-warnings
Apr 8, 2026
Merged

chore(repo): fix all oxlint errors and warnings#160
zrosenbauer merged 6 commits intomainfrom
chore/fix-lint-warnings

Conversation

@zrosenbauer
Copy link
Copy Markdown
Member

Summary

  • Resolve all 55 warnings and 1 error reported by oxlint
  • Replace toBe(true/false) with toBeTruthy()/toBeFalsy() across test files
  • Use object/array destructuring instead of direct member access
  • Rename describe titles that collide with imported function names
  • Capitalize continuation comments to satisfy capitalized-comments rule
  • Replace ternary with ts-pattern match in config middleware (the 1 error)
  • Name anonymous async generator in log test

Test plan

  • pnpm check passes (typecheck + lint + format)
  • pnpm test passes (all 17 tasks successful)

Resolve 55 warnings and 1 error across the codebase:
- Replace toBe(true/false) with toBeTruthy/toBeFalsy
- Use object/array destructuring instead of member access
- Rename describe titles to avoid matching imported function names
- Capitalize continuation comments
- Replace ternary with ts-pattern match in config middleware
- Name anonymous async generator in log test

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
oss-kidd Ignored Ignored Preview Apr 8, 2026 8:06pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 8, 2026

🦋 Changeset detected

Latest commit: 6aae715

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2635c5f2-50fc-4e5a-b556-8a5cd436a480

📥 Commits

Reviewing files that changed from the base of the PR and between ece55ac and 6aae715.

📒 Files selected for processing (2)
  • packages/core/src/context/resolve-defaults.test.ts
  • packages/core/src/stories/check.test.ts

📝 Walkthrough

Walkthrough

This PR updates test assertions across multiple packages to use truthiness matchers (toBeTruthy(), toBeFalsy()) instead of strict boolean equality comparisons, changes several test describe blocks to reference imported functions directly instead of string labels, applies minor destructuring refactors to test snapshot access, and adjusts comment capitalization and wording in source files and configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately summarizes the main objective: fixing linting errors and warnings reported by oxlint.
Description check ✅ Passed Description is directly related to the changeset, providing specific detail about the linting fixes, test assertion updates, and refactoring applied.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/fix-lint-warnings

Comment @coderabbitai help to get the list of available commands and usage tips.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 8, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing chore/fix-lint-warnings (6aae715) with main (f050fd1)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

zrosenbauer and others added 5 commits April 8, 2026 15:05
…orkarounds

Co-Authored-By: Claude <noreply@anthropic.com>
…pression

Constants like MAX_EDITABLE_FIELDS (number) and EMPTY_CLACK_BASE (object)
produce useless describe names when passed by reference.

Co-Authored-By: Claude <noreply@anthropic.com>
The rule cannot distinguish constants from functions, so it fires on
describe('MAX_EDITABLE_FIELDS', ...) and describe('EMPTY_CLACK_BASE', ...)
where passing the reference would produce useless names like "6" or
"[object Object]". Disabled globally; function-ref convention is followed
organically.

Co-Authored-By: Claude <noreply@anthropic.com>
…ession

Keep the rule enabled globally. Suppress with eslint-disable-next-line
only for constants (MAX_EDITABLE_FIELDS, EMPTY_CLACK_BASE) where passing
the reference would produce useless describe names.

Co-Authored-By: Claude <noreply@anthropic.com>
@zrosenbauer zrosenbauer merged commit 23bf68a into main Apr 8, 2026
12 checks passed
@zrosenbauer zrosenbauer deleted the chore/fix-lint-warnings branch April 8, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant