chore(repo): fix all oxlint errors and warnings#160
Conversation
Resolve 55 warnings and 1 error across the codebase: - Replace toBe(true/false) with toBeTruthy/toBeFalsy - Use object/array destructuring instead of member access - Rename describe titles to avoid matching imported function names - Capitalize continuation comments - Replace ternary with ts-pattern match in config middleware - Name anonymous async generator in log test Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
🦋 Changeset detectedLatest commit: 6aae715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR updates test assertions across multiple packages to use truthiness matchers ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
…orkarounds Co-Authored-By: Claude <noreply@anthropic.com>
…pression Constants like MAX_EDITABLE_FIELDS (number) and EMPTY_CLACK_BASE (object) produce useless describe names when passed by reference. Co-Authored-By: Claude <noreply@anthropic.com>
The rule cannot distinguish constants from functions, so it fires on
describe('MAX_EDITABLE_FIELDS', ...) and describe('EMPTY_CLACK_BASE', ...)
where passing the reference would produce useless names like "6" or
"[object Object]". Disabled globally; function-ref convention is followed
organically.
Co-Authored-By: Claude <noreply@anthropic.com>
…ession Keep the rule enabled globally. Suppress with eslint-disable-next-line only for constants (MAX_EDITABLE_FIELDS, EMPTY_CLACK_BASE) where passing the reference would produce useless describe names. Co-Authored-By: Claude <noreply@anthropic.com>
Summary
oxlinttoBe(true/false)withtoBeTruthy()/toBeFalsy()across test filesdescribetitles that collide with imported function namescapitalized-commentsrulets-patternmatchin config middleware (the 1 error)Test plan
pnpm checkpasses (typecheck + lint + format)pnpm testpasses (all 17 tasks successful)