feat(toolkit-cleaner): use a durable Lambda function

[jogold]

Use a Lambda durable function instead of a Step Function.

Fixes #290

BREAKING CHANGE: ToolkitCleaner schedule prop renamed to scheduleExpression and now accepts ScheduleExpression from aws-cdk-lib/aws-scheduler instead of Schedule from aws-cdk-lib/aws-events

[gemini-code-assist]

Summary of Changes

Hello @jogold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the ToolkitCleaner construct by transitioning its asset cleaning logic from an AWS Step Functions state machine to a single, durable AWS Lambda function. This change streamlines the architecture, consolidates multiple Lambda functions into one, and updates the scheduling mechanism to use AWS EventBridge Scheduler, aiming for improved efficiency and maintainability.

Highlights

• Architecture Simplification: The ToolkitCleaner construct has been refactored to use a single durable AWS Lambda function, replacing the previous AWS Step Functions state machine for asset cleaning.
• Function Consolidation: The logic previously distributed across four separate Lambda functions (clean-images, clean-objects, extract-template-hashes, get-stack-names) has been consolidated into a single clean.lambda.ts file.
• Scheduling Mechanism Update: The scheduled execution of the cleaner has been migrated from AWS EventBridge Rules (using aws-cdk-lib/aws-events.Schedule) to the more modern AWS EventBridge Scheduler (using aws-cdk-lib/aws-scheduler.ScheduleExpression).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great improvement, refactoring the toolkit-cleaner from a Step Function with multiple Lambdas into a single, durable Lambda function using @aws/durable-execution-sdk-js. This significantly simplifies the architecture and reduces boilerplate code. The switch to aws-scheduler from aws-events is also a welcome modernization. I've found one potential bug that could cause the Lambda to crash and one suggestion to further improve maintainability by reducing code duplication.

[jogold]

/gemini review

[gemini-code-assist]

Code Review

This pull request is a significant and well-executed refactoring of the ToolkitCleaner construct. It replaces the previous Step Functions-based implementation with a single, durable Lambda function using the @aws/durable-execution-sdk-js. This change simplifies the architecture considerably. The new implementation is well-structured, notably with the use of a strategy pattern for cleaning different asset types, and is supported by a comprehensive suite of tests. I have identified two critical issues: one concerning the Lambda timeout configuration that could lead to deployment or runtime failures, and another that could cause a runtime TypeError in the Lambda function. Please see my detailed comments for suggestions on how to resolve these.