Add support for method_exists() guards#12
Merged
johnbillion merged 3 commits intojohnbillion:method-existsfrom Oct 30, 2024
Merged
Add support for method_exists() guards#12johnbillion merged 3 commits intojohnbillion:method-existsfrom
method_exists() guards#12johnbillion merged 3 commits intojohnbillion:method-existsfrom
Conversation
staabm
commented
Oct 30, 2024
| use PHPStan\Node\Printer\ExprPrinter; | ||
| use function count; | ||
|
|
||
| final class MethodExistsVisitor extends NodeVisitorAbstract { |
Contributor
Author
There was a problem hiding this comment.
I tried several variants, even those mentioned in phpstan/phpstan#11648
I went with the visitor, as I got the impression that this SinceVersionRule is expected to work on the $requiresAtLeast parameter of SinceVersionRule, no matter which version of wordpress itself is installed at the time of analysis.
Contributor
Author
|
I think this should work as a initial iteration (in case you don't have remarks) |
johnbillion
approved these changes
Oct 30, 2024
Owner
johnbillion
left a comment
johnbillion
left a comment
There was a problem hiding this comment.
Thank you so much Markus. This is all looking good and everything is passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementation for #6
in case you find more variants which needs fixing and are not covered yet, please send another failing test-case and I will provide a followup