Remove redundant manual EnsureApproval calls from MCP tools#78
Merged
Remove redundant manual EnsureApproval calls from MCP tools#78
Conversation
… attributes Co-authored-by: johnkord <16021727+johnkord@users.noreply.github.com>
Co-authored-by: johnkord <16021727+johnkord@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Many of the tools have EnsureApproval checks in the code for the MCP tools even if they don't have RequiresApproval annotation
Remove redundant manual EnsureApproval calls from MCP tools
Jun 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all manual
ToolApprovalManager.Instance.EnsureApproved()calls from MCP tool methods, ensuring that tool approval is controlled exclusively by the[RequiresApproval]attribute through theToolApprovalWrappersystem.Problem
Many MCP tools had both:
[RequiresApproval]attributes on methodsEnsureApproved()calls within the method implementationsThis created redundant approval logic and violated the design principle that the
[RequiresApproval]attribute should be the single source of truth for approval requirements.Solution
Removed manual approval calls from methods WITH
[RequiresApproval]:ShellTools.RunCommand()FileTools.WriteFile(),DeleteFile(),CreateDirectory()HttpTools.HttpRequest()CodeReviewTools.GenerateReviewComment()GitHubTools.PostPullRequestComment()Removed manual approval calls from methods WITHOUT
[RequiresApproval]:GetPullRequest,GetPullRequestFiles, etc.)AnalyzePullRequestForReview,ExtractCodePatterns)Impact
ToolApprovalWrapperThe approval system continues to work correctly - tools with
[RequiresApproval]are automatically wrapped with approval logic, while tools without the attribute execute immediately.Fixes #77.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.