fix: update stale model IDs in e2e tests#31
Merged
johnnichev merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
- Anthropic: claude-3-haiku-20240307 → claude-haiku-4-5 (old model retired) - Gemini: gemini-2.0-flash → gemini-2.5-flash (old model deprecated for new users) - Fix Gemini API key check to accept GOOGLE_API_KEY in addition to GEMINI_API_KEY - Fix flaky streaming assertion (short responses can be 1 chunk) All 136 e2e tests pass across OpenAI, Anthropic, and Gemini.
johnnichev
added a commit
that referenced
this pull request
Apr 7, 2026
Addresses 4 items from the latest Galaxy S23 review round plus one new desktop instruction. 1. **Hidden nav drawer leaving a visible line at the top of the header** (Image #29): the previous `transform: translateY(-110%)` with a `border-bottom: 1px solid` on .nav-drawer was leaving a faint sub-pixel artifact depending on viewport/DPR. Replaced with `opacity: 0 + visibility: hidden + transform: translateY(-8px)`, using transition-delay to sequence visibility correctly on open (immediate) vs close (after fade-out completes). The drawer is now completely invisible and non-interactive when closed — no peek, no interactive hit zone. 2. **Huge gap between "24 Built-in Tools" and "Multi-Agent Orchestration" on mobile** (Image #30): the `mt-16` (64px) between the grid-4 and grid-2 card sections created a visible "end of section" break mid-content when both collapse to single column. Added a mobile/touch override that reduces mt-16 to match the in-grid gap (14px), so the cards read as one continuous list. 3. **pip install button looks bad on desktop** (Image #31): completely replaced the old .btn-pip squished-text button with a full terminal install component inspired by the nv-context-landing pattern the user pointed at. Structure: ┌─ ● ● ● ~/your-project [Copy] ─┐ │ │ │ $ pip install selectools█ │ │ │ └────────────────────────────────────────────────────┘ - Rounded container with cyan-tinted hover glow - Mac-style traffic-light dots (red/yellow/green) - `~/your-project` filename in the chrome - `$ pip install selectools` with cyan prompt, white cmd, blinking cyan caret - Reveal-on-hover "Copy" button (always visible on touch) - Whole component is click-to-copy with Enter/Space keyboard support - "Copied" flash on the Copy button + bottom toast notification - Full clipboard API with execCommand fallback for insecure contexts Replaces the old `<button class="btn btn-pip">` + `copyPip()` JS. The "Try the Builder" and "Read the Docs" buttons move below as a standard two-button CTA row. Far more visually distinctive and intuitive than a button labeled "pip install selectools". 4. **Desktop header auto-hide** (new instruction): removed the nav-hide-on-scroll-down behavior on desktop too. The header now stays permanently fixed on all viewports — the previous progressive-enhancement auto-hide was confusing even on desktop. Also removed the now-dead .nav-hidden CSS class and the `allowHide` logic in the scroll-progress IIFE. Also cleaned up: - Removed `.nav-drawer { display: block }` overrides from both media queries — the drawer is always `display: block` default now, with visibility controlling appearance. Simpler, fewer rules. - Added `.terminal-body .caret` and `.terminal-install:hover` neutralization in the prefers-reduced-motion block. - Added `@media (hover: none)` guard to prevent transform lift on touch.
21 tasks
johnnichev
added a commit
that referenced
this pull request
Apr 7, 2026
…43) Addresses 4 items from the latest Galaxy S23 review round plus one new desktop instruction. 1. **Hidden nav drawer leaving a visible line at the top of the header** (Image #29): the previous `transform: translateY(-110%)` with a `border-bottom: 1px solid` on .nav-drawer was leaving a faint sub-pixel artifact depending on viewport/DPR. Replaced with `opacity: 0 + visibility: hidden + transform: translateY(-8px)`, using transition-delay to sequence visibility correctly on open (immediate) vs close (after fade-out completes). The drawer is now completely invisible and non-interactive when closed — no peek, no interactive hit zone. 2. **Huge gap between "24 Built-in Tools" and "Multi-Agent Orchestration" on mobile** (Image #30): the `mt-16` (64px) between the grid-4 and grid-2 card sections created a visible "end of section" break mid-content when both collapse to single column. Added a mobile/touch override that reduces mt-16 to match the in-grid gap (14px), so the cards read as one continuous list. 3. **pip install button looks bad on desktop** (Image #31): completely replaced the old .btn-pip squished-text button with a full terminal install component inspired by the nv-context-landing pattern the user pointed at. Structure: ┌─ ● ● ● ~/your-project [Copy] ─┐ │ │ │ $ pip install selectools█ │ │ │ └────────────────────────────────────────────────────┘ - Rounded container with cyan-tinted hover glow - Mac-style traffic-light dots (red/yellow/green) - `~/your-project` filename in the chrome - `$ pip install selectools` with cyan prompt, white cmd, blinking cyan caret - Reveal-on-hover "Copy" button (always visible on touch) - Whole component is click-to-copy with Enter/Space keyboard support - "Copied" flash on the Copy button + bottom toast notification - Full clipboard API with execCommand fallback for insecure contexts Replaces the old `<button class="btn btn-pip">` + `copyPip()` JS. The "Try the Builder" and "Read the Docs" buttons move below as a standard two-button CTA row. Far more visually distinctive and intuitive than a button labeled "pip install selectools". 4. **Desktop header auto-hide** (new instruction): removed the nav-hide-on-scroll-down behavior on desktop too. The header now stays permanently fixed on all viewports — the previous progressive-enhancement auto-hide was confusing even on desktop. Also removed the now-dead .nav-hidden CSS class and the `allowHide` logic in the scroll-progress IIFE. Also cleaned up: - Removed `.nav-drawer { display: block }` overrides from both media queries — the drawer is always `display: block` default now, with visibility controlling appearance. Simpler, fewer rules. - Added `.terminal-body .caret` and `.terminal-install:hover` neutralization in the prefers-reduced-motion block. - Added `@media (hover: none)` guard to prevent transform lift on touch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-3-haiku-20240307→claude-haiku-4-5(old model retired by Anthropic)gemini-2.0-flash→gemini-2.5-flash(old model deprecated for new users)GOOGLE_API_KEYin addition toGEMINI_API_KEYTest Results
136 e2e tests pass across OpenAI, Anthropic, and Gemini (9 skipped = Ollama not running).