Conversation
There was a problem hiding this comment.
Pull request overview
Updates InjectionNext for a Bazel 9-related submodule revision and bumps the app version while addressing a small client-connection regression in InjectionServer.
Changes:
- Update
InjectionLitesubmodule commit reference. - Adjust
InjectionServer.currentClientsto treat “no active connections” uniformly. - Bump InjectionNext version (marketing + build).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| InjectionLite | Updates the submodule commit to a newer revision (Bazel 9 / regression fix). |
| App/InjectionNext/InjectionServer.swift | Refines currentClients computation using a compacted list of active connections. |
| App/InjectionNext/Info.plist | Increments CFBundleVersion build number. |
| App/InjectionNext.xcodeproj/project.pbxproj | Increments MARKETING_VERSION to 1.5.4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
0d86ab5 to
77ae54e
Compare
622951c to
222828f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
7d3719a to
e09153b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
App/InjectionNext/MonitorXcode.swift:1
- Inside the
autoreleasepool { ... }closure,returnexits only the closure (not the surroundingwhileloop / function). This is easy to misread as an early-exit frommonitorXcode(...). Recommendation (optional): restructure to avoidreturnhere (e.g., wrap the main body in anifand fall through, or add a short comment like// return from autoreleasepool iterationright above it) to make the control flow unambiguous.
//
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Bazel 9, thread safety, consolidate code, fix very minor regression.