Skip to content

Workthree#122

Merged
johnno1962 merged 7 commits intomainfrom
workthree
Mar 25, 2026
Merged

Workthree#122
johnno1962 merged 7 commits intomainfrom
workthree

Conversation

@johnno1962
Copy link
Copy Markdown
Owner

@johnno1962 johnno1962 commented Mar 12, 2026

Bazel 9, thread safety, consolidate code, fix very minor regression.

@johnno1962 johnno1962 requested a review from Copilot March 12, 2026 11:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates InjectionNext for a Bazel 9-related submodule revision and bumps the app version while addressing a small client-connection regression in InjectionServer.

Changes:

  • Update InjectionLite submodule commit reference.
  • Adjust InjectionServer.currentClients to treat “no active connections” uniformly.
  • Bump InjectionNext version (marketing + build).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
InjectionLite Updates the submodule commit to a newer revision (Bazel 9 / regression fix).
App/InjectionNext/InjectionServer.swift Refines currentClients computation using a compacted list of active connections.
App/InjectionNext/Info.plist Increments CFBundleVersion build number.
App/InjectionNext.xcodeproj/project.pbxproj Increments MARKETING_VERSION to 1.5.4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@johnno1962 johnno1962 requested a review from Copilot March 13, 2026 22:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@johnno1962 johnno1962 force-pushed the workthree branch 2 times, most recently from 0d86ab5 to 77ae54e Compare March 14, 2026 10:16
@johnno1962 johnno1962 force-pushed the workthree branch 3 times, most recently from 622951c to 222828f Compare March 14, 2026 14:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@johnno1962 johnno1962 force-pushed the workthree branch 2 times, most recently from 7d3719a to e09153b Compare March 14, 2026 18:53
@johnno1962 johnno1962 requested a review from Copilot March 19, 2026 10:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

App/InjectionNext/MonitorXcode.swift:1

  • Inside the autoreleasepool { ... } closure, return exits only the closure (not the surrounding while loop / function). This is easy to misread as an early-exit from monitorXcode(...). Recommendation (optional): restructure to avoid return here (e.g., wrap the main body in an if and fall through, or add a short comment like // return from autoreleasepool iteration right above it) to make the control flow unambiguous.
//

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@johnno1962 johnno1962 merged commit e124f3d into main Mar 25, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants