fix: show skipped count when all files already synced#54
Merged
Conversation
When all subtitle files are already synced, the scan now creates a run with total_files=0 and skipped=N (the count of already-synced files) instead of throwing 'Process completed without starting a run'. The run history and UI will show the skipped count so users can see that the scan completed successfully with nothing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48
When a scan finds 0 unprocessed files (because everything is already synced), the app previously threw "Process completed without starting a run" which looked like an error.
Now it creates a run with
total_files=0andskipped=Nshowing how many files were already synced. The run completes immediately and shows up in history with the skipped count, so users can see the scan worked — there was just nothing to do.