Skip to content

117 ancova combined column revised#227

Draft
iaugusty wants to merge 5 commits intodevfrom
117-ancova-combined-column-revised
Draft

117 ancova combined column revised#227
iaugusty wants to merge 5 commits intodevfrom
117-ancova-combined-column-revised

Conversation

@iaugusty
Copy link
Collaborator

@iaugusty iaugusty commented Mar 10, 2026

Pull Request

Fixes #117

Checks

  • (Have you updated the changelog.md ?)

- extend list of available stats for summarize_ancova_j
- add tests for ancova in combined column
@iaugusty iaugusty changed the base branch from main to dev March 10, 2026 12:21
- add tests for incorrect weights_combo specifications
@iaugusty
Copy link
Collaborator Author

@danielinteractive : could you take a look at the proposed approach for dealing with estimations from ancova model in combined column? I'm using a weighted approach where the proposed weights are independent from the existing weights_emmeans parameter. Your input would be highly appreciated, before going into discussion with stats.
No default has been set (on purpose) and the user would have to make their choice regarding weights_combo.

@munoztd0
Copy link
Collaborator

All good as for our templates at least -> https://github.com/munoztd0/scda.test/actions/runs/22907556675/job/66470541626?pr=4

@danielinteractive
Copy link
Collaborator

Thanks @iaugusty , I think it will be best to first discuss with you to understand more the context and idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: afuns that call s_ancova_j in a layout with combined groups result in error

3 participants