-
-
Notifications
You must be signed in to change notification settings - Fork 179
Finicky 4 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the Finicky 4 release by updating configuration handling, example usage, and update checking defaults while refreshing the README to reflect new version details.
- Update getOption to accept a generic default value
- Modify example configuration export to use the TypeScript satisfies operator
- Pass a default value for update checking in Go
- Revise README content and links to align with Finicky 4
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/config-api/src/index.ts | Update getOption signature to include a generic parameter and default value |
| example-config/example.ts | Export configuration directly using satisfies operator |
| apps/finicky/src/version/version.go | Set default value for checkForUpdates option in update checking call |
| README.md | Refresh documentation to reflect Finicky 4 changes and updated links |
Files not reviewed (1)
- apps/finicky/assets/Info.plist: Language not supported
Comments suppressed due to low confidence (1)
apps/finicky/src/version/version.go:208
- Adding the default value 'true' changes the behavior of update checking. Verify that this default precisely meets the intended configuration expectations.
shouldCheckForUpdates, err := vm.RunString("finickyConfigAPI.getOption('checkForUpdates', finalConfig, true)")
packages/config-api/src/index.ts
Outdated
| } | ||
|
|
||
| export function getOption( | ||
| export function getOption<T>( |
Copilot
AI
Apr 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generic parameter T is added for getOption, but the function still returns unknown. Consider updating the return type to T to improve type safety and clarity.
Release preparation
Fixes #393