Skip to content

Conversation

@johnste
Copy link
Owner

@johnste johnste commented Apr 9, 2025

Release preparation

Fixes #393

  • Update README with Finicky 4 imagery and configuration
  • Update wiki pages, tagging existing v3 pages as unsupported
  • Add new wiki pages for v4 (configuration, tips, etc)
  • Update examples
  • Update version
  • Enable update checking by default

@johnste johnste requested a review from Copilot April 26, 2025 17:04
@johnste johnste marked this pull request as ready for review April 26, 2025 17:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the Finicky 4 release by updating configuration handling, example usage, and update checking defaults while refreshing the README to reflect new version details.

  • Update getOption to accept a generic default value
  • Modify example configuration export to use the TypeScript satisfies operator
  • Pass a default value for update checking in Go
  • Revise README content and links to align with Finicky 4

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/config-api/src/index.ts Update getOption signature to include a generic parameter and default value
example-config/example.ts Export configuration directly using satisfies operator
apps/finicky/src/version/version.go Set default value for checkForUpdates option in update checking call
README.md Refresh documentation to reflect Finicky 4 changes and updated links
Files not reviewed (1)
  • apps/finicky/assets/Info.plist: Language not supported
Comments suppressed due to low confidence (1)

apps/finicky/src/version/version.go:208

  • Adding the default value 'true' changes the behavior of update checking. Verify that this default precisely meets the intended configuration expectations.
shouldCheckForUpdates, err := vm.RunString("finickyConfigAPI.getOption('checkForUpdates', finalConfig, true)")

}

export function getOption(
export function getOption<T>(
Copy link

Copilot AI Apr 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generic parameter T is added for getOption, but the function still returns unknown. Consider updating the return type to T to improve type safety and clarity.

Copilot uses AI. Check for mistakes.
@johnste johnste merged commit 9c1f2d1 into main May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v4 Stable release preparation

2 participants